RFR: 8348038: Docs build failing in Options.notifyListeners with AssertionError [v2]

[Jan Lahoda]

On Sun, 19 Jan 2025 20:49:23 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> The change in [JDK-8347474](https://bugs.openjdk.org/browse/JDK-8347474) caused `make all-docs-bundles` to start failing. This PR includes a fix for that.
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace previous unit test with one that fails before the fix.

I think this is OK in order to fix the broken build quickly. But, the handling of the symbol files for javadoc appears to be quite convoluted, as `ToolEnvironment` hard-disables the symbol file anyway:
https://github.com/openjdk/jdk/blob/4b4b1e912a3193cc95c956acc770015f707449b1/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolEnvironment.java#L145

It would probably be good to file a followup cleanup task to seem if we can do something nicer/better/cleaner.

(FWIW, I've submitted a build with this change, but it will probably take some time before it finishes.)

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23192#pullrequestreview-2561788410
PR Comment: https://git.openjdk.org/jdk/pull/23192#issuecomment-2601849837