RFR: 8326485: Assertion due to Type.addMetadata adding annotations to already-annotated type

[Aggelos Biboudis]

We end up with an errorType having annotation metadata (which subsequently results in this assertion getting invalidated after `Type ret = typeWithAnnotations(type, enclTy, annotations);` is executed).

What if we continue to try to define the `enclTy` (iteratively)? The error can still be reported appropriately. If this PR is merged it reproduces the original test case by running as expected: many errors without a crash:


javac src/main/java/net/ccbluex/liquidbounce/injection/mixins/minecraft/gui/MixinChatInputSuggestor.java -cp /tmp/jars/annotations-20.1.0.jar:/tmp/jars/kotlin-compiler-embeddable-1.9.0.jar


WDYT?

-------------

Commit messages:
 - 8326485: Assertion due to Type.addMetadata adding annotations to already-annotated type

Changes: https://git.openjdk.org/jdk/pull/23272/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23272&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326485
  Stats: 44 lines in 3 files changed: 42 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/23272.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23272/head:pull/23272

PR: https://git.openjdk.org/jdk/pull/23272