RFR: 8348212: Need to add warn() step to JavacTaskImpl after JDK-8344148 [v2]

[Maurizio Cimadamore]

On Fri, 24 Jan 2025 16:55:28 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a regression test.
>
> test/langtools/tools/javac/api/TestJavacTaskWithWarning.java line 45:
> 
>> 43: import javax.tools.ToolProvider;
>> 44: 
>> 45: public class TestJavacTaskWithWarning extends TestJavacTask {
> 
> We don't seem to have any other test doing this... what are you using of the super class?

probably just add

static final JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
static final StandardJavaFileManager fm = compiler.getStandardFileManager(null, null, null);
 ```
 to the test and get rid of the dependency? Seems to be what other tests are doing in here...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23223#discussion_r1928981961