Integrated: 8348212: Need to add warn() step to JavacTaskImpl after JDK-8344148

Archie Cobbs acobbs at openjdk.org
Sat Jan 25 18:05:52 UTC 2025


On Tue, 21 Jan 2025 23:42:29 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> In [JDK-8344148](https://bugs.openjdk.org/browse/JDK-8344148) a new `warn()` compiler phase was added and `JavaCompiler.java` was updated accordingly.
> 
> However, the class `JavacTaskImpl` also walks through the compiler phases step-by-step, but the new `warn()` step was never added there. This will cause some warnings to not be emitted when that API is used.
> 
> This PR adds the missing `warn()` calls.

This pull request has now been integrated.

Changeset: 5431668c
Author:    Archie Cobbs <acobbs at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5431668cb92a8ef2ccfe1059db1cde0e5d98adce
Stats:     90 lines in 2 files changed: 88 ins; 0 del; 2 mod

8348212: Need to add warn() step to JavacTaskImpl after JDK-8344148

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/jdk/pull/23223


More information about the compiler-dev mailing list