RFR: 8224228: No way to locally suppress lint warnings in parser/tokenizer or preview features
Archie Cobbs
acobbs at openjdk.org
Fri Jan 31 18:40:48 UTC 2025
On Thu, 23 Jan 2025 22:02:07 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Question: the change looks beneficial, but there's a lot going on in the PR. Would it be possible, do you think, to break it down into simpler parts? For instance, the push/pop logic seems something that we could review and integrate separately (and it's adding quite a bit of noise to the PR). Same for missing flushes etc.
>
>> Hi @mcimadamore,
>>
>> Thanks for taking a look.
>>
>> > Would it be possible, do you think, to break it down into simpler parts?
>>
>> Absolutely, I will work on that.
>
> Thanks!!
@mcimadamore,
> Would it be possible, do you think, to break it down into simpler parts?
I've split this into three precursor "cleanup" PR's (although the third one is new and wasn't part of the original change).
So this PR depends on (i.e., includes and extends) these others. Obviously they would need to be adjudicated first:
* #23167
* #23281
* #23400
Let me know if this looks like a reasonable approach. I'm happy to split things up differently if needed. Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23237#issuecomment-2628054367
More information about the compiler-dev
mailing list