RFR: 8357185: Redundant local variables with unconditionally matching primitive patterns [v2]

Aggelos Biboudis abimpoudis at openjdk.org
Thu Jul 3 20:56:38 UTC 2025


On Thu, 3 Jul 2025 20:45:54 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 2840:
>> 
>>> 2838:             if (types.isUnconditionallyExact(tree.expr.type, tree.pattern.type)) {
>>> 2839:                 // instanceOfExpr; true
>>> 2840:                 sideEffect = make.Exec(instanceOfExpr);
>> 
>> maybe `evaluatedLHS` or `memoizedLHS`.
>
> This is not really a lhs - we are trying to generate "statement; expression", maybe rename this to `prefixStatement`?

True. Yes, good name. Go for it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26107#discussion_r2183737197


More information about the compiler-dev mailing list