RFR: 8357185: Redundant local variables with unconditionally matching primitive patterns [v2]
Jan Lahoda
jlahoda at openjdk.org
Fri Jul 4 17:44:40 UTC 2025
On Fri, 4 Jul 2025 07:37:16 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:
>> I think we aim to name tests by the content instead of uninformative bug ids - ids are tracked with the bug jtreg directive.
>
> Both styles are adopted as we can observe in `jdk/test/langtools/tools/javac`.
>
> In any case the current name is definitely not descriptive as it has nothing to do with unconditionally exact testing inherently. This is done in `test/jdk/java/lang/runtime/ExactnessConversionsSupportTest.java` or other tests. Unconditionally exact conversion is the context but not the observed effect.
>
> The test name can be either `T8357185` or something descriptive like `RedundantVariablesInPrimitivePatterns`.
The `T<number>` format is mostly frowned upon, and we mostly try to not use the convention for new tests. If we can have a good name, that's better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26107#discussion_r2185851338
More information about the compiler-dev
mailing list