RFR: 8357653: Inner classes of type parameters emitted as raw types in signatures [v12]

Aggelos Biboudis abimpoudis at openjdk.org
Thu Jul 10 12:20:41 UTC 2025


On Thu, 10 Jul 2025 10:54:14 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review 2
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 2238:
> 
>> 2236: 
>> 2237:     /**
>> 2238:      * Calls `asSuper(S, sym)` on a sequence of types until a match is found.
> 
> nit: I wonder if we need to update this comment as the implementation is not directly invoking asSuper after all, same for method `asEnclosingSuper`

True. I revised the text a bit trying to make "the sequence" stand out a bit more while keeping it as abstract as possible. There is a bit duplication on the first paragraph but it seems clear to me. However have another look to confirm that it is clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25451#discussion_r2197565978


More information about the compiler-dev mailing list