Integrated: 8357653: Inner classes of type parameters emitted as raw types in signatures

[Aggelos Biboudis]

On Mon, 26 May 2025 15:51:06 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

> There are various occasions that the qualifier of an _inner type_ needs to be normalized. 
> 
> Briefly:
> 
> - This occurs when there is an explicit type application in the signature of the method or a type application operation or when type checking an expression operation (e.g., `G.Getter` in the first example, `M.B<?>` in the second example). 
> - The reference to an inner type may not be explicitly qualified (e.g., `B<?>` which is not qualified but its type needs be calculated as seen from `A<String>.B<?>`).
> 
> Semi-formally: 
> 
> - A type reference is simple name `R`:
> 
>   - `R` is a non-inner class type, nothing to do
>   - `R` is an inner class type, we need to find an implicit type qualifier `S<T>.R`, where `S` is the class in which `R` is enclosed
>   - `R` is an array type `A[]`, repeat the analysis for the simple type name `A`, and then use the implicit type qualifier to rewrite the array
> 
> - A type reference is a qualified name `Q.R`
>   
>   - find the supertype of `Q`, namely `S<T>`, where `S` is the class in which `R` is enclosed
> 
> 
> 
> // example 1
> static class Usage1<T, G extends Getters<T>> {
>   public T test(G.Getter getter) {
>       return getter.get();
>   }
> }
> 
> // example 2
> class A<T> {
>   protected class B<V> {}
> 
>   public static <T, M extends A<T>> void f(Object g) {
>     @SuppressWarnings("unchecked")
>     M.B<?> mapping = (M.B<?>) g;
>   }
> }
> 
> // example 3
> class A<T> {
>     class B<W> {
>         public T rett() { return null; }
>     }
> }
> 
> class C extends A<String> {
>     static class D {
>         {
>             B<?> b = null;
>             String s = b.rett();
>         }
>     }
> }

This pull request has now been integrated.

Changeset: 5e4a2ead
Author:    Aggelos Biboudis <abimpoudis at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5e4a2ead714814cb4eb90ca88debc226f9c75864
Stats:     452 lines in 5 files changed: 399 ins; 28 del; 25 mod

8357653: Inner classes of type parameters emitted as raw types in signatures
8357472: NPE in Types.containsType for type variable used as a qualifier

Co-authored-by: Maurizio Cimadamore <mcimadamore at openjdk.org>
Reviewed-by: mcimadamore, vromero, liach

-------------

PR: https://git.openjdk.org/jdk/pull/25451