RFR: 8361424: Eliminate Log methods mandatoryWarning() and mandatoryNote()

Thu Jul 17 21:45:49 UTC 2025

On Thu, 17 Jul 2025 18:34:07 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> I agree with you in principle; the "only one flag" design choice was [already in place](https://github.com/openjdk/jdk/blob/347084bfbdbf048cd50c0e13e43ae53f6da77e6e/src/jdk.compiler/share/classes/com/sun/tools/javac/util/AbstractLog.java#L124)

You are actually correct, I made confusion with the duplicated factories under DiagnosticFactory, some of those do take an enumset of flags.

So, if I'm correct, this patch only adds some missing factories to warning/note, right? If so, good. We can revisit the number of factories as a separate cleanup (I'm not too proud also of the duplication in DiagnosticFactory, which predate the whole `DiagnosticInfo` stuff. But a problem for another day.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26138#issuecomment-3085612912