Integrated: 8361424: Eliminate Log methods mandatoryWarning() and mandatoryNote()
Archie Cobbs
acobbs at openjdk.org
Fri Jul 18 01:46:53 UTC 2025
On Fri, 4 Jul 2025 18:24:50 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:
> The fix for [JDK-8359493](https://bugs.openjdk.org/browse/JDK-8359493) added the ability to associate `DiagnosticFlag`'s to specific warnings at the point of definition in `compiler.properties`. In cases where the flag is an inherent property of the warning itself, `compiler.properties` is a more appropriate place to declare it, instead of having to add it at all the points in the codebase where that particular warning is used.
>
> In particular, the Log API methods `mandatoryWarning()` and `mandatoryNote()` can be removed, as they serve only to add the `MANDATORY` flag to warnings and notes for which "mandatoryness" is inherent. Doing so should help decomplexify the code a bit.
This pull request has now been integrated.
Changeset: cab51596
Author: Archie Cobbs <acobbs at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/cab515962b6940b50b975b12c8f5e99d0430f694
Stats: 103 lines in 9 files changed: 8 ins; 48 del; 47 mod
8361424: Eliminate Log methods mandatoryWarning() and mandatoryNote()
Reviewed-by: mcimadamore
-------------
PR: https://git.openjdk.org/jdk/pull/26138
More information about the compiler-dev
mailing list