RFR: 8362885: A more formal way to mark javac's Flags that belong to a specific Symbol type only

[Chen Liang]

On Thu, 24 Jul 2025 07:21:12 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> This PR proposes to improve handling of javac's `Flags` in two ways:
> - for each flag, there's now an informational annotation specifying what is the target Symbol type. Only targets right now are `TypeSymbol`s, `MethodSymbol`s and `VarSymbol`s. If we ran out of flags for `TypeSymbol`s, we could split those to module/package/class/type variable, but it does not seem to be quite necessary yet. There's an auxiliary special `BLOCK`, which is for `JCBlock`.
> - the manually handled `Flags.Flag` enum is replaced with autogenerated `FlagsEnum`
> 
> This is inspired by:
> https://github.com/openjdk/jdk/pull/26181#pullrequestreview-2997428662
> 
> There may be some better to handle `Flags` eventually, but this hopefully improves the current situation at least somewhat, by providing more formal way to say the flags' target, and restricting the need to read comments and search for free flags.
> 
> As a side-effect of this annotation, the `test/langtools/tools/javac/flags/FlagsTest.java` now also prints which flags are free, for each Symbol type.
> 
> (I will remove the `build` label for now, until discussion on javac level is done, and will re-add it if we decide the goal to autogenerate the FlagsEnum makes sense.)

make/langtools/tools/flagsgenerator/FlagsGenerator.java line 85:

> 83:             try (PrintWriter out = new PrintWriter(Files.newBufferedWriter(Paths.get(args[1])))) {
> 84:                 out.println("""
> 85:                             package com.sun.tools.javac.code;

Do we need a license header for generated sources?

test/langtools/tools/javac/flags/FlagsTest.java line 102:

> 100:     private static void printFreeFlags(String comment, long freeFlags) {
> 101:             System.err.print("free flags for " + comment + ": ");
> 102:             for (int bit = 16; bit < 64; bit++) { //lowest 16 bits are used in classfiles, never suggest adding anything there

Replace 16 with Character.SIZE and 64 with Long.SIZE?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26452#discussion_r2229222407
PR Review Comment: https://git.openjdk.org/jdk/pull/26452#discussion_r2229216762