RFR: 8356645: Javac should utilize new ZIP file system read-only access mode [v5]
David Beaumont
duke at openjdk.org
Mon Jul 28 10:07:44 UTC 2025
On Wed, 11 Jun 2025 05:43:31 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/FSInfo.java line 183:
>>
>>> 181: * {@code null} to ignore release versioning).
>>> 182: */
>>> 183: public static Map<String, ?> readOnlyJarFSEnv(String releaseVersion) {
>>
>> I named this after the getJarFSProvider() method above, since they are used in close proximity, but would be happy to consider other names.
>
> I am a bit uneasy about having the method static, as this class's API is normally instance methods. I think that an instance of FSInfo (`fsInfo`) is available in both `JavacFileManager` and `Locations`, so it would be better to simply have an instance method. (The static field is OK, that's not an API.)
@lahodaj thoughts?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2235678530
More information about the compiler-dev
mailing list