RFR: 8356645: Javac should utilize new ZIP file system read-only access mode [v6]

David Beaumont duke at openjdk.org
Mon Jul 28 16:40:36 UTC 2025


On Mon, 28 Jul 2025 13:23:52 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updating to latest local changes.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/FSInfo.java line 25:
> 
>> 23:  * questions.
>> 24:  */
>> 25: 
> 
> Nit: could you please update copyright dates in all files

Done. I could have sworn I'd done these. Thanks for spotting.

> test/langtools/tools/javac/platform/VerifyCTSymClassFiles.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8331027
>> 27:  * @summary Verify classfile inside ct.sym
> 
> Could you please add the bug id to the `@bug`, as this is a src change

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2237213561
PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2237213676


More information about the compiler-dev mailing list