RFR: 8358066: Non-ascii package names gives compilation error "import requires canonical name" [v2]
Naoto Sato
naoto at openjdk.org
Tue Jun 3 23:28:17 UTC 2025
On Mon, 2 Jun 2025 19:05:37 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:
>> A simple counting bug in `Convert.utfNumChars()` causes bogus compiler errors for `import` statements of non-ASCII class names when the compiler is configured to use one of the older UTF-8 based `Name` table implementations (e.g., by specifying the `-XDuseUnsharedTable=true` flag).
>
> Archie Cobbs has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix glitch in exception message.
> - Simplify code using review suggestion.
> That's for another PR though, I am loath to further delay this one at this point since it's already approved and the JDK 25 lop off happens tomorrow
Totally fine by me
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25567#pullrequestreview-2894373139
More information about the compiler-dev
mailing list