RFR: 8356645: Javac should utilize new ZIP file system read-only access mode
David Beaumont
duke at openjdk.org
Wed Jun 4 13:19:43 UTC 2025
This PR seeks to integrate the new ZipFileSystem "accessMode" parameter to open internal ZIP/JAR files as read only, to act as defense in-depth against accidental modification.
Note that this currently also propagates the (currently undocumented) "zipinfo-time" parameter to several other places where ZIP/JAR files are opened, which is likely to improve performance. This was discussed and is expected to be safe (but it's something to be careful about).
This will, of course, be thoroughly tested before integration.
It also unifies several places to use a common helper method to obtain the environment map, adds more comments, and changes a small number of affected tests.
I'm also happy to update the original bug description to include the timestamp related changes as necessary.
-------------
Commit messages:
- restore JavaCompiler error change
- Integrate read-only ZIP/JAR files into Javac.
Changes: https://git.openjdk.org/jdk/pull/25639/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25639&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8356645
Stats: 100 lines in 7 files changed: 71 ins; 13 del; 16 mod
Patch: https://git.openjdk.org/jdk/pull/25639.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25639/head:pull/25639
PR: https://git.openjdk.org/jdk/pull/25639
More information about the compiler-dev
mailing list