RFR: 8356645: Javac should utilize new ZIP file system read-only access mode

[David Beaumont]

On Thu, 5 Jun 2025 00:01:29 GMT, Chen Liang <liach at openjdk.org> wrote:

>> test/langtools/tools/javac/jvm/ClassRefDupInConstantPoolTest.java line 46:
>> 
>>> 44: 
>>> 45: public class ClassRefDupInConstantPoolTest {
>>> 46: 
>> 
>> This test was failing and needed to be compiling its own class file rather than reading the one in the test library.
>
> The class file is from this test file instead of the test libraries, and this pattern of shipping additional classes in the same compilation unit for class file handling in tests is common in jdk/classfile and other packages. Could the `clean` directive be the culprit?

It's possible. I remember having to change this when I prototyped the new code a while ago, but I'm not sure I remember exactly why. I can try reverting it if the original style is acceptable (personally I prefer to compile on-the-fly since it can test the compiler with different options - which is probably why I changed it originally).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2137921970