RFR: 8356645: Javac should utilize new ZIP file system read-only access mode
Jan Lahoda
jlahoda at openjdk.org
Thu Jun 12 06:55:37 UTC 2025
On Wed, 11 Jun 2025 10:27:18 GMT, David Beaumont <duke at openjdk.org> wrote:
>> For me: not relying on `assert` is preferred, esp. in tests. I.e. what is here currently seems good to me.
>
> But you would be okay with this assert, or just happy to shrug and leave it as read-write if it somehow wasn't a ZIP file system? Alternately we could do what I see done elsewhere and extract the ZIP file system provider and use it directly?
I think this test is verifying `ct.sym` is sensible, and we can extend that to make sure the file can be opened in the correct way. I.e., I would keep the check at this place as you did.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2141856934
More information about the compiler-dev
mailing list