RFR: 8356645: Javac should utilize new ZIP file system read-only access mode [v3]

David Beaumont duke at openjdk.org
Thu Jun 19 10:03:35 UTC 2025


On Wed, 18 Jun 2025 20:28:25 GMT, David Beaumont <duke at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some (not all) feedback addressed. Still open questions.
>
> test/langtools/tools/javac/platform/VerifyCTSymClassFiles.java line 60:
> 
>> 58:     }
>> 59: 
>> 60:     private final FSInfo fsInfo = FSInfo.instance(new Context());
> 
> I don't think this is actually right unless we make the other cySym code use FSInfo. Happy to hear people's thoughts on this. One benefit here is that we know we've matched the expected ZIP file with the ZIP file system provider, so no need to worry if the environment was going to be honoured.

I changed both case (test and code) to NOT use FSInfo now. The dependency and extra code (esp. now the method is an instance method) just doesn't seem worth it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2156621191


More information about the compiler-dev mailing list