RFR: 8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Jun 23 20:57:31 UTC 2025
On Mon, 23 Jun 2025 18:28:47 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:
> > > I have to admit I don't really get why `isExplicitEnabled/Disabled` takes an `Option` parameter -- I see them always invoked with `Option.XLINT`. Because of that, I'm not even sure they belong much in `Options` at all -- an instance method on `LintCategory` which accepts `Options` would perhaps look simpler for clients?
> >
> >
> > Note: the same is true for the new methods `isEnabled`/`isDisabled` added in this PR -- they feel `Lint`-specific methods to me.
>
> It's to allow for future customization of other lint-related options, in particular `-Werror` - see #23622.
>
> Maybe that's a little too leading? I can remove it if you prefer.
Yeah, I think for now I'd prefer that. I believe each PR should be relatively standalone -- maybe we will go ahead and follow up with the other PR, but I'd prefer to avoid adding more stuff here which is really needed to support that other task.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25840#issuecomment-2997915926
More information about the compiler-dev
mailing list