RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea [v2]
Eric Caspole
ecaspole at openjdk.org
Thu Mar 6 19:51:46 UTC 2025
> The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.
Eric Caspole has updated the pull request incrementally with one additional commit since the last revision:
Fix header and remove unused Blackhole
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23917/files
- new: https://git.openjdk.org/jdk/pull/23917/files/8c882666..649957dc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23917&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23917&range=00-01
Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/23917.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23917/head:pull/23917
PR: https://git.openjdk.org/jdk/pull/23917
More information about the compiler-dev
mailing list