RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea [v2]

[Chen Liang]

On Thu, 6 Mar 2025 19:51:46 GMT, Eric Caspole <ecaspole at openjdk.org> wrote:

>> The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH  which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.
>
> Eric Caspole has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix header and remove unused Blackhole

Indeed, these tests uses a static non-final field as the sink of work, which should be equivalent to using a blackhole. We can remove this unused blackhole safely.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23917#pullrequestreview-2668307561