RFR: 8338675: javac shouldn't silently change .jar files on the classpath [v4]
David Beaumont
duke at openjdk.org
Mon Mar 10 19:18:12 UTC 2025
On Thu, 6 Mar 2025 17:05:25 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adding a test for the annotation processing Filer.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java line 921:
>
>> 919: // Use the sibling to determine the output location where possible, unless
>> 920: // it is in a JAR/ZIP file (we don't attempt to write class files back into
>> 921: // archives). See JDK-8338675.
>
> Per usual JDK coding conventions, we don't put bug numbers into source code.
I wasn't aware of this. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23699#discussion_r1987879314
More information about the compiler-dev
mailing list