RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v6]

[Maurizio Cimadamore]

On Thu, 13 Mar 2025 15:52:37 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 246 commits:
>> 
>>  - Merge branch 'master' into implement-jep502
>>  - Clean up exception messages and fix comments
>>  - Rename field
>>  - Rename method and fix comment
>>  - Rework reenterant logic
>>  - Use acquire semantics for reading rather than volatile semantics
>>  - Add missing null check
>>  - Simplify handling of sentinel, wrap, and unwrap
>>  - Fix JavaDoc issues
>>  - Fix members in StableEnumFunction
>>  - ... and 236 more: https://git.openjdk.org/jdk/compare/4e51a8c9...d6e1573f
>
> src/java.base/share/classes/java/lang/StableValue.java line 497:
> 
>> 495: 
>> 496:     /**
>> 497:      * {@return a new unset stable supplier}
> 
> Should we say "unset" here?

E.g. we do not define the term "unset supplier" anywhere -- we just define what a stable supplier is -- IMHO that's enough. Also... whether unset or set, that's not really visible by the user?

> src/java.base/share/classes/java/lang/StableValue.java line 564:
> 
>> 562: 
>> 563:     /**
>> 564:      * {@return a new unset stable function}
> 
> Should we say "unset" here?

Same with all the other lazy XYZ factories

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r1993830847
PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r1993832264