RFR: 8352389: Remove incidental whitespace in pre/code content [v3]

Hannes Wallnöfer hannesw at openjdk.org
Thu Mar 20 07:27:39 UTC 2025


> Please review a change to remove incidental whitespace commonly found at the beginning of `<pre><code>` or `<pre>{@code` tags. This patch is dependent on [JDK-8352249](https://bugs.openjdk.org/browse/JDK-8352249) and completes the removal of incidental whitespace in traditional doc comments. 
> 
> This is implemented by parsing content of `<pre>` elements into a separate list buffer in `DocCommentParser`, and filter the content for leading blank linkes when the element is closed. The decision to filter `<pre>` element contents only once the element is closed was made in order to be able to keep the logic in a single method without further complicating other parts of `DocCommentParser`.

Hannes Wallnöfer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:

 - Merge branch 'master' into JDK-8352389
 - Improve test
 - Add comment
 - 8352389: Remove incidental whitespace in pre/code content
 - Whitespace normalization in PrettyCheck becomes simpler
 - Rename method
 - Update comment
 - Clean up code, add comments, tests and @bug id
 - Updated copyright year in testSourceTab breaks test
 - Update remaining doctree tests & copyright headers
 - ... and 4 more: https://git.openjdk.org/jdk/compare/fb210e3a...5ec3bc04

-------------

Changes: https://git.openjdk.org/jdk/pull/24112/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24112&range=02
  Stats: 354 lines in 7 files changed: 342 ins; 3 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/24112.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24112/head:pull/24112

PR: https://git.openjdk.org/jdk/pull/24112


More information about the compiler-dev mailing list