RFR: 8338675: javac shouldn't silently change .jar files on the classpath [v7]

[Joe Darcy]

On Mon, 24 Mar 2025 09:49:09 GMT, David Beaumont <duke at openjdk.org> wrote:

>> Modifying `JavacFileManager` to skip creating sibling output class files for source files found in JARs.
>> 
>> This should match older (JDK 8) behavior whereby the JAR was not writable, and results in any newly generated class files being written to the current working directory (the output of class files into current directory isn't good, but it should match the old behavior).
>
> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused import.

test/langtools/tools/javac/processing/filer/TestNoOverwriteJarFiles.java line 81:

> 79:  * an existing class file entry. This would be very problematic.
> 80:  * <p>
> 81:  * This test ensures javac will not modify JAR files on the classpath, even if

Does something reasonable happen if the soucepath and classpath are both set to the same jar file?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23699#discussion_r2021748372