RFR: 8345431: Detect duplicate entries in jar files with jar --validate [v6]

[Henry Jen]

On Wed, 7 May 2025 17:13:19 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restore Validator access level
>
> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 127:
> 
>> 125: 
>> 126:         public DedupEntryNames(boolean isCEN) {
>> 127:             this.isCEN = isCEN;
> 
> Might be clearer if this was an enum vs boolean?

I feel the same way but wondering if that's an overkill.

> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 147:
> 
>> 145:                 warn(formatMsg(msg, count.toString(), counter.getKey()));
>> 146:             }
>> 147:             return true;
> 
> This seems to always be true as `warn()` results in `err.println` call (unless I am missing something)

I should clean that up better. As we just want to show the message but not really filter out that entry.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2078195738
PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2078193636