RFR: 8356441: IllegalStateException in RichDiagnosticFormatter after JDK-8355065

[Chen Liang]

On Thu, 8 May 2025 16:10:39 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> test/langtools/tools/javac/annotations/typeAnnotations/RichFormatterWithTypeAnnotationsReentrantTest.java line 126:
>> 
>>> 124:                         "^",
>>> 125:                         "1 error",
>>> 126:                         "1 warning");
>> 
>> These messages are locale specific. I don't know if we can detect the keys for these messages instead.
>
> Thanks! For the purposes of the test the diagnostic text doesn't matter as long as the compiler isn't crashing. I'll look to see if there's a good way to get the diagnostic codes here, another option might be to just relax the assertion to not match on the output.

Yep, or running with jtreg options or flags to ensure the locale of the JVM would work too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25105#discussion_r2080125064