RFR: 8336470: Source launcher should work with service loader SPI in unnamed module [v7]

[Christian Stein]

On Fri, 9 May 2025 08:19:37 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update copyright year
>>    
>>    [skip ci]
>>  - User copyright text w/o `"Classpath" exception`
>>    
>>    [skip ci]
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/MemoryClassLoader.java line 278:
> 
>> 276:      */
>> 277:     private URL toResourceInRootPath(String name) {
>> 278:         var file = programDescriptor.sourceRootPath().resolve(name);
> 
> "name" is an abstract resource name, so it's a '/' separated sequence of names. Is there is mapping step missing here?

Hm, if it missing, it was missing before. I moved the line from the former location with a different variable name:
`var programPath = programDescriptor.sourceRootPath().resolve(name);` into this new helper method. All tests and manual usages remain "green".

Which kind of mapping are you missing here? From `/` to `\` or `.`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20193#discussion_r2081212514