RFR: 8356441: IllegalStateException in RichDiagnosticFormatter after JDK-8355065 [v2]

[Maurizio Cimadamore]

On Thu, 8 May 2025 17:51:13 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> [JDK-8355065](https://bugs.openjdk.org/browse/JDK-8355065) fixed an issue where if RichDiagnosticFormatter was used recursively, it would overwrite instance state. That fix added guards to prevent the logic from being used recursively. As reported in [JDK-8356441](https://bugs.openjdk.org/browse/JDK-8356441) there are other situations where RichDiagnosticFormatter is used recursively. This fixes updates it to support being used recursively, by saving and restoring instance state on recursive calls.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Avoid asserting on localized text
>  - Merge remote-tracking branch 'origin/master' into b416188790
>  - Imports
>  - 8356441: IllegalStateException in RichDiagnosticFormatter after JDK-8355065

Marked as reviewed by mcimadamore (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25105#pullrequestreview-2828480418