RFR: 8325859: potential information loss during type inference [v3]

Vicente Romero vromero at openjdk.org
Mon May 12 11:08:52 UTC 2025


On Sat, 10 May 2025 19:40:24 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8325859
>>  - make visitor static
>>  - updating doc
>>  - 8325859: potential information loss during type inference
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/InferenceContext.java line 657:
> 
>> 655:                "Undet vars: " + undetvars + '\n';
>> 656:         /*
>> 657:         // keep it for debugging
> 
> Should we control this with an `options.isSet` switch instead, maybe passing the options through Infer?

yes we could do that, but then we will probably want to add a test for that option, etc, probably not worthy, also we could just drop this code

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25011#discussion_r2084438563


More information about the compiler-dev mailing list