RFR: 8325859: potential information loss during type inference [v3]

[Vicente Romero]

On Thu, 15 May 2025 17:59:45 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>>> Actually I think that one of our performance tests failed and that was why I had to introduce this visitor if I recall correctly
>> 
>> I wanted to ask about this -- e.g. how much fixing this undoes the benefit of minimization. It seems we're in tricky territory.
>> 
>> Now, the problem with the visitor is that it picks up any type-variables -- it should at least filter out class type-variables and focus on method type-variables.
>
> How feasible would it be to collect all the variables from all the supplimentary contexts, and then to only one subst? I assume the cost is with `types.subst` which is a visitor?

> > Actually I think that one of our performance tests failed and that was why I had to introduce this visitor if I recall correctly
> 
> I wanted to ask about this -- e.g. how much fixing this undoes the benefit of minimization. It seems we're in tricky territory.
> 
> Now, the problem with the visitor is that it picks up any type-variables -- it should at least filter out class type-variables and focus on method type-variables.

the difference in performance is negligible

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25011#discussion_r2091780130