RFR: 8350212: Track source end positions of declarations that support @SuppressWarnings [v7]

[Maurizio Cimadamore]

On Fri, 30 May 2025 01:51:40 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> This PR is a sub-task split off from [JDK-8224228](https://bugs.openjdk.org/browse/JDK-8224228), which seeks to add `@SuppressWarnings` support for lexical features.
>> 
>> Lexical features don't know about classes, members or symbols, so their source file positions must be matched to the source file character offset range of the innermost containing `JCModuleDecl`, `JCPackageDecl`, `JCClassDecl`, `JCMethodDecl`, or `JCVariableDecl`. That means we need the end positions of all such declarations to be available.
>> 
>> The parser doesn't normally store lexical end positions unless explicitly requested, and we don't want to mandate it for performance reasons.
>> 
>> Instead, we can just add an `int endPos` field to these five AST nodes. This field can be populated as part of the normal parsing of these node types, which already supports the (optional) tracking of end positions.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Revert TreeInfo.endPos() refactoring except for "bracePos" renaming.
>  - Merge branch 'master' into JDK-8350212
>  - Merge branch 'master' into JDK-8350212 to fix conflict.
>  - Update copyrights.
>  - Refactoring/cleanup for handling of ending positions.
>  - Add missing variable decl end position.
>  - Add end position for variables coming from variableDeclaratorId().
>  - Track source end positions of declarations that support @SuppressWarnings.

src/jdk.compiler/share/classes/com/sun/tools/javac/tree/EndPosTable.java line 72:

> 70:      * @param errPos The error position
> 71:      */
> 72:     void setErrorEndPos(int errPos);

Why was this added to the interface? (separately, I think interface + abstract class + concrete impl is a bit of an overkill here -- but that's for another day)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23669#discussion_r2115623353