RFR: 8355753: @SuppressWarnings("this-escape") not respected for indirect leak via field [v3]

[Archie Cobbs]

On Thu, 29 May 2025 20:13:50 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove extraneous semicolons.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java line 1794:
> 
>> 1792:               IntStream.range(0, that.stack.size())
>> 1793:                 .allMatch(index -> this.stack.get(numExtra + index).comparePos(that.stack.get(index)) == 0);
>> 1794:         };
> 
> Suggestion:
> 
>         }

Thanks - fixed in f79e35f8ee6.

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java line 1814:
> 
>> 1812:                     return diff;
>> 1813:             }
>> 1814:         };
> 
> Suggestion:
> 
>         }

Thanks - fixed in f79e35f8ee6.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24932#discussion_r2115924911
PR Review Comment: https://git.openjdk.org/jdk/pull/24932#discussion_r2115924750