RFR: 8155591: Misleading warning when not overriding close method in interface extending AutoCloseable [v3]
Archie Cobbs
acobbs at openjdk.org
Wed Nov 5 18:23:27 UTC 2025
> The compiler generates a warning if you declare a `close()` method that throws any supertype of `InterruptedException` in a class or interface extending `AutoCloseable`. This is because suppressed `InterruptedException`'s are likely to lead to misbehavior at runtime.
>
> However, this feature also generates a warning due to `AutoCloseable.close()` itself, if you simply inherit it. For example:
>
> $ cat MyClass.java
> public interface MyClass extends AutoCloseable {
> }
> $ javac -Xlint:try MyClass.java
> MyClass.java:1: warning: [try] auto-closeable resource MyClass has a member method close() that could throw InterruptedException
> public interface MyClass extends AutoCloseable {
> ^
> 1 warning
>
> The warning is not useful because `AutoCloseable.close()` is abstract and so it's going to be some other class' job to deal with the throws clause.
>
> This change prevents `AutoCloseable.close()` itself from triggering the warning in a class declaration. We preserve the existing behavior in which a warning is generated at the use site (i.e., at the try-with-resources statement).
Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Add more regression test variants.
- Fix missed warning when close() method implemented in superclass.
- Merge branch 'master' into JDK-8155591
- Merge branch 'master' into JDK-8155591 to get recent build fixes.
- Don't warn about AutoCloseable.close() itself throwing InterruptedException.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27062/files
- new: https://git.openjdk.org/jdk/pull/27062/files/3f769967..d9b78c60
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27062&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27062&range=01-02
Stats: 129414 lines in 2312 files changed: 73962 ins; 40822 del; 14630 mod
Patch: https://git.openjdk.org/jdk/pull/27062.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27062/head:pull/27062
PR: https://git.openjdk.org/jdk/pull/27062
More information about the compiler-dev
mailing list