RFR: 8268613: jar --validate should check inital entries of a JAR file
Alan Bateman
alanb at openjdk.org
Mon Nov 10 10:41:03 UTC 2025
On Wed, 5 Nov 2025 17:29:10 GMT, Christian Stein <cstein at openjdk.org> wrote:
> Please review this change to include a validation check for expecting an optional JAR manifest entry being the first or second entry in JAR file. As the second entry, it must be only preceeded by an entry for the `META-INF/` directory.
src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 257:
> 255: errorAndInvalid(formatMsg("error.validator.wrong.position", firstName, "0"));
> 256: }
> 257: }
This looks right, except that `entryInfo.cen().order()` is confusing to read. At some point we need to re-visit EntryEncounter and EntryInfo as the naming is very confusing. The cen member suggests it returns the CEN, and the order member is confusing too. Maybe
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28154#discussion_r2509860450
More information about the compiler-dev
mailing list