RFR: 8370800: Downgrade cant.attach.type.annotations diagnostics to warnings [v8]

[Jan Lahoda]

On Sun, 9 Nov 2025 18:30:53 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> Hi, please consider this fix for [JDK-8370800: Downgrade cant.attach.type.annotations diagnostics to warnings](https://bugs.openjdk.org/browse/JDK-8370800).
>> 
>> As discussed in the, this reduces the compatibility impact of these diagnostics for builds that deliberately omit transitive annotation dependencies, for example if they are only referenced through javadoc `@link` tags, or by frameworks that conditionally load the classes.
>> 
>> The PR changes the existing error diagnostic to an unconditional warning. Another alternative would be to make it an optional xlint diagnostic, perhaps as part of `-Xlint:classfile`, or as another category.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Complete symbols returned by getAllMembers

I was looking into this a bit more. I am afraid I don't see any really good solution. So, out of the not-so-good solutions, the original solution seems least problematic. (With the `DeferredCompletionFailureHandler`, of course, we can't ignore the `CompletionFailure`s completely.) I suspect this probably should be documented in a CSR.

@jddarcy, what do you think?

Sorry for the fuss.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28018#issuecomment-3517036952