RFR: 8370334: javadoc NPE with "import module" statement [v2]

Vicente Romero vromero at openjdk.org
Fri Nov 14 22:04:04 UTC 2025


On Mon, 3 Nov 2025 16:19:27 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> `Modules.enter` completes all root modules, but in case of additional modules being added to the module graph via `Modules.addExtraAddModules` (either from javadoc, or using the `CompilationTask.addModules`, these extra modules may not be completed at this time. Normally, they are completed eventually, but if their `module-info`s contain `import module`, an NPE will appear while checking the import, before the complete happens.
>> 
>> The proposal herein is to consistently complete all modules in the module graph when the module graphs is setup.
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Don't eagerly complete the unnamed module.

looks sensible

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27974#pullrequestreview-3466997830


More information about the compiler-dev mailing list