RFR: 8372023: Javac JMH failures

[Chen Liang]

On Wed, 19 Nov 2025 18:49:15 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> There are two issues here, change for [1] implied that some code that was acceptable before this change would be rejected by the compiler. This had provoked an that some JMH tests started failing. This can be fixed by compiling those cases with `-source 25`. Also while taking a look at this issue I realized that the fix for [1] had a bug which it is also being fixed here.
> 
> TIA
> 
> [1] https://bugs.openjdk.org/browse/JDK-8369517

Marked as reviewed by liach (Reviewer).

test/benchmarks/micros-javac/src/main/java/org/openjdk/bench/langtools/javac/JavacBenchmark.java line 191:

> 189:             }
> 190:         }) {
> 191:             String[] cmdLine = new String[] {"-source", "25", "-XDcompilePolicy=simple", "-implicit:none", "-nowarn", "--module-source-path", root.toString(), "-d", root.toString(), "-XDignore.symbol.file=true", "@" + srcList.toString()};

I recommend adding a comment in pom of this project that they need to bump the source version here if they bump the source compiled by this benchmark: https://github.com/openjdk/jdk/blob/7b11bd1b1d8dbc9bedcd8cf14e78c8f5eb06a71f/test/benchmarks/micros-javac/pom.xml#L31

-------------

PR Review: https://git.openjdk.org/jdk/pull/28400#pullrequestreview-3488018507
PR Review Comment: https://git.openjdk.org/jdk/pull/28400#discussion_r2546177328