RFR: 8369039: JDK-8348611 caused regression in Javac-Hot-Generate [v3]

Claes Redestad redestad at openjdk.org
Wed Oct 8 23:37:10 UTC 2025


On Wed, 8 Oct 2025 15:31:21 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> I was curious if that would make any difference (using [this additional patch](https://github.com/archiecobbs/jdk/compare/JDK-8369039...archiecobbs:jdk:JDK-8369039-opt1)). When I try it on my laptop I get a slight improvement:

Can't reallt establish any statistically significant difference either way here, neither on score or allocations. 

So just to understand this a bit better I instrumented to see how common that condition is and it seems that when  `tree.getTag() == Tree.PACKAGEDEF` then `tree.annotations` is never empty. At least in this benchmark. Perhaps the case when there are no annotations are skipped earlier?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27651#discussion_r2415235378


More information about the compiler-dev mailing list