Integrated: 8367499: Refactor exhaustiveness computation from Flow into a separate class
Jan Lahoda
jlahoda at openjdk.org
Tue Oct 21 07:25:15 UTC 2025
On Fri, 12 Sep 2025 09:49:14 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> Currently the switch exhaustiveness computation code is part of `Flow`. And while conceptually the check is part of the `Flow` phase, the code is >500 lines of code currently, and likely to get bigger/more complicated in the future. Among other reasons due to enhancements like https://bugs.openjdk.org/browse/JDK-8367530.
>
> The proposal herein is to move the exhaustiveness computation to a separate class `ExhastivenessComputer`. There's no functional change, only move of the code. This is intentional, to aid the review process.
>
> One possibility to inspect what is happening is:
>
> git show upstream/master:src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java >/tmp/Flow-original.java
> diff -d -w /tmp/Flow-original.java src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ExhaustivenessComputer.java >/tmp/exhaustivenesscomputer-comparison.diff
> diff -d -w /tmp/Flow-original.java src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java >/tmp/flow-comparison.diff
>
> and inspecting `/tmp/exhaustivenesscomputer-comparison.diff`, `/tmp/flow-comparison.diff`.
This pull request has now been integrated.
Changeset: 430041d3
Author: Jan Lahoda <jlahoda at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/430041d366ddf450c2480c81608dde980dfa6d41
Stats: 1146 lines in 2 files changed: 605 ins; 538 del; 3 mod
8367499: Refactor exhaustiveness computation from Flow into a separate class
Reviewed-by: vromero
-------------
PR: https://git.openjdk.org/jdk/pull/27253
More information about the compiler-dev
mailing list