RFR: 8369428: Include method name in 'does not override or implement' diagnostics [v3]

Chen Liang liach at openjdk.org
Mon Oct 27 21:28:59 UTC 2025


On Mon, 27 Oct 2025 21:25:26 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> Hi,
>> 
>> Please consider this small improvement to `compiler.err.method.does.not.override.superclass` diagnostics, to include the method name.
>> 
>> Before:
>> 
>> 
>> T.java:2: error: method does not override or implement a method from a supertype
>>   @Override
>>   ^
>> 
>> 
>> After:
>> 
>> 
>> T.java:2: error: f() does not override or implement a method from a supertype
>>   @Override
>>   ^
>> 1 error
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8369428
>  - Update more diagnostics
>  - 8369428: Include method name in 'does not override or implement' diagnostics

Sorry for a very late reply but this does look much more informative.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27692#pullrequestreview-3385522674


More information about the compiler-dev mailing list