RFR: 8366678: Use JUnit in test/langtools/tools/javac [v3]

Christian Stein cstein at openjdk.org
Thu Sep 4 20:48:44 UTC 2025


On Thu, 4 Sep 2025 20:42:08 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor test classes to have a unique constructor
>>   
>>   That way, Jupiter doesn't need the help of a custom test instance factory
>
> test/langtools/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerDefault.java line 81:
> 
>> 79: 
>> 80:             q = MethodReferenceTestInnerDefault.this::xs_B_;
>> 81:             assertEquals("_B_xsB:*", q.m("*"));
> 
> why changing the order of the arguments?

> The order of the expected and actual arguments to assertion methods such as `assertEquals(...)` needs to be swapped so that the expected result precedes the actual result.

https://github.com/junit-team/junit-framework/wiki/Migrating-from-TestNG-to-JUnit-Jupiter

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27046#discussion_r2323514057


More information about the compiler-dev mailing list