RFR: 8359383: Incorrect starting positions for implicitly typed variables [v2]

Vicente Romero vromero at openjdk.org
Fri Sep 5 02:06:21 UTC 2025


On Mon, 11 Aug 2025 18:17:35 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> This fixes starting position bugs relating to implicitly typed variables; see the linked issue for details.
>> 
>> This also makes it possible to recover the declaration type (explicit, implicit, or `var`) from a `JCVariableDecl` and, in the case of `var` declarations, the starting position of the `var`; previously this wasn't possible.
>> 
>> Finally, as a minor drive-by improvement, we can now pretty print `var` as `var` instead of `/*missing*/`.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Add back regression test case that got removed somehow.
>  - Merge branch 'master' into JDK-8359383
>  - Fix various starting position bugs relating to implicitly typed variables.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25786#pullrequestreview-3187785504


More information about the compiler-dev mailing list