RFR: 8366582: Test jdk/jshell/ToolSimpleTest.java failed: provider not found
SendaoYan
syan at openjdk.org
Wed Sep 17 09:05:21 UTC 2025
On Wed, 17 Sep 2025 08:15:21 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> The `jdk/jshell/ToolSimpleTest.java` randomly fails, the reason is this: when indexing the bootclasspath/`PLATFORM_CLASS_PATH`, `$JDK_HOME/lib/modules` is typically there, but it can't be opened as a FileSystem, and the exception is sent to the debugging facility. The debugging facility typically does nothing, but in this test contains a test case that enabled debugging, and if the order of things is that the debugging is first enabled, and then the `ProviderNotFoundException` is reported, the test fails.
>
> The proposal herein is to not to try to open `$JDK_HOME/lib/modules` as a file system. Note the standard platform classes are indexed using `SYSTEM_MODULES`.
src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysisImpl.java line 2307:
> 2305: if (!Files.isDirectory(path)) {
> 2306: if (Files.exists(path) &&
> 2307: !isJRTMarkerFile(path)) { //don't directly index lib/modules
Suggestion:
!isJRTMarkerFile(path)) { //don't directly index lib/modules
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27333#discussion_r2354828223
More information about the compiler-dev
mailing list