RFR: 8367499: Refactor exhaustiveness computation from Flow into a separate class [v2]
Jan Lahoda
jlahoda at openjdk.org
Mon Sep 29 05:37:06 UTC 2025
> Currently the switch exhaustiveness computation code is part of `Flow`. And while conceptually the check is part of the `Flow` phase, the code is >500 lines of code currently, and likely to get bigger/more complicated in the future. Among other reasons due to enhancements like https://bugs.openjdk.org/browse/JDK-8367530.
>
> The proposal herein is to move the exhaustiveness computation to a separate class `ExhastivenessComputer`. There's no functional change, only move of the code. This is intentional, to aid the review process.
>
> One possibility to inspect what is happening is:
>
> git show upstream/pr/27247:src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java >/tmp/Flow-original.java
> diff -d -w /tmp/Flow-original.java src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ExhaustivenessComputer.java >/tmp/exhaustivenesscomputer-comparison.diff
> diff -d -w /tmp/Flow-original.java src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java >/tmp/flow-comparison.diff
>
> and inspecting `/tmp/exhaustivenesscomputer-comparison.diff`, `/tmp/flow-comparison.diff`.
Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
Adding doc comment.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27253/files
- new: https://git.openjdk.org/jdk/pull/27253/files/0d778871..69638358
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27253&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27253&range=00-01
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/27253.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27253/head:pull/27253
PR: https://git.openjdk.org/jdk/pull/27253
More information about the compiler-dev
mailing list