RFR: 8370800: Downgrade cant.attach.type.annotations diagnostics to warnings [v8]

[Liam Miller-Cushon]

On Sun, 9 Nov 2025 18:30:53 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> Hi, please consider this fix for [JDK-8370800: Downgrade cant.attach.type.annotations diagnostics to warnings](https://bugs.openjdk.org/browse/JDK-8370800).
>> 
>> As discussed in the, this reduces the compatibility impact of these diagnostics for builds that deliberately omit transitive annotation dependencies, for example if they are only referenced through javadoc `@link` tags, or by frameworks that conditionally load the classes.
>> 
>> The PR changes the existing error diagnostic to an unconditional warning. Another alternative would be to make it an optional xlint diagnostic, perhaps as part of `-Xlint:classfile`, or as another category.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Complete symbols returned by getAllMembers

I've heard of at least one more recent example of a cant.attach.type.annotations diagnostic requiring a workaround. I think the symbol completion option here has the best ergonomics, but also still have concerns about the downsides of using field/method completers for this. I'd like to leave this open for a bit longer to keep thinking about it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28018#issuecomment-3880230019