RFR: 8377601: JavacTemplateTestBase not reporting javac crashes [v2]
Chen Liang
liach at openjdk.org
Wed Feb 11 23:47:11 UTC 2026
On Wed, 11 Feb 2026 16:32:00 GMT, Chen Liang <liach at openjdk.org> wrote:
>> JavacTemplateTestBase does not fail if javac crashes. A javac crash is not reflected in the diagnostics, but rather printed in System.err, which can be redirected. We should redirect that stream and ensure that stream is empty for our test cases.
>>
>> This test framework bug is discovered during project valhalla bworld prototype development in https://github.com/openjdk/valhalla/pull/2075
>
> Chen Liang has updated the pull request incrementally with two additional commits since the last revision:
>
> - Redundant import
> - Simplified the logic - ct.generate throws already
Thanks for the review!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29659#issuecomment-3887843848
More information about the compiler-dev
mailing list