RFR: 8308637: AssertionError when using Trees.getScope in plug-in [v2]

Jan Lahoda jlahoda at openjdk.org
Thu Feb 19 19:23:52 UTC 2026


On Thu, 19 Feb 2026 17:31:32 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback: cleanup/removing comment.
>
> test/langtools/tools/javac/api/TestGetScopeResult.java line 1052:
> 
>> 1050:                                 @Override
>> 1051:                                 public Void visitIdentifier(IdentifierTree node, Void p) {
>> 1052:                                     //                                if (getCurrentPath().getParentPath().getLeaf().getKind() == Kind.NEW_CLASS) {
> 
> can we remove this comment?

Sorry I missed that. Fixed ([2a30c91](https://github.com/openjdk/jdk/pull/29739/commits/2a30c91d031626d518b29c072d02fe6350817678)). Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29739#discussion_r2829715611


More information about the compiler-dev mailing list