RFR: 8374434: Several JShell tests report JUnit discovery warnings
Jaikiran Pai
jpai at openjdk.org
Wed Jan 7 10:15:07 UTC 2026
On Mon, 5 Jan 2026 12:00:52 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> JShell tests where converted to use JUnit instead of TestNG by this commit:
> https://github.com/openjdk/jdk/commit/b0ca9bf61e0390a3b022a0915eacabb0cfd92e93
>
> As part of the conversion, the `@Test` annotation had to be copied from classes to test methods, as JUnit requires every test method to be annotated. Sadly the tool doing the conversion moved the annotation to some non-test methods as well. This PR fixes that. The tool has been fixed as well.
Hello Jan, this looks good to me.
In an upcoming jtreg release, issues like these will be easily noticed as this will lead to a test failure https://bugs.openjdk.org/browse/CODETOOLS-7904125.
The copyright years on these files will need an update before integrating.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29034#pullrequestreview-3634187719
More information about the compiler-dev
mailing list